Rotopax are a solid choice. Only issues really come in with the fact that they don't vent. So if they are laying flat you can't easily burp them when the temperature changes. If the are on a side so you have the cap on top it's pretty easy, but flat can be a pain.
Jerry cans are pretty bomber but take up a bit more space. If they are cheap or really old they could be rusted on the inside. They also make plastic ones as well that have their own issues.